tools: enable unicode-bom ESLint rule#11479
Closed
addaleax wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
sam-github
approved these changes
Feb 21, 2017
Trott
reviewed
Feb 21, 2017
.eslintrc.yaml
Outdated
Member
There was a problem hiding this comment.
For consistency with the rest of the file, please place unicode-bom under Stylistic Issues in alphabetical order with the other rules (so last in the list of Stylistic Issues). No need for a comment or anything, as there's a link at the top of Stylistic Issues, although I don't mind the comment either, so ¯\(ツ)/¯
Trott
approved these changes
Feb 21, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with a nit + if CI linter is green
Disallow UTF-8 Byte Order Marks in the source tree. That Node can read these files is still tested by `test/sequential/test-module-loading.js`.
Member
Author
|
@Trott done! |
Contributor
|
@addaleax Thank you, Sorry. |
Member
Author
|
@vsemozhetbyt No problem! I noticed it a bit too late myself. 😄 Also, it’s not like there was an actual rule for this before, it’s just something that occasionally throws off editors. ¯\_(ツ)_/¯ |
cjihrig
approved these changes
Feb 21, 2017
jasnell
approved these changes
Feb 22, 2017
lpinca
approved these changes
Feb 22, 2017
silverwind
approved these changes
Feb 23, 2017
Contributor
silverwind
left a comment
silverwind
left a comment
There was a problem hiding this comment.
LGTM. I checked our .editorconfig and we're already covered through charset = utf-8 (as opposed to utf-8-bom).
Member
Author
addaleax
added a commit
that referenced
this pull request
Feb 24, 2017
PR-URL: #11479 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 24, 2017
Disallow UTF-8 Byte Order Marks in the source tree. That Node can read these files is still tested by `test/sequential/test-module-loading.js`. PR-URL: #11479 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 24, 2017
PR-URL: #11479 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
added a commit
that referenced
this pull request
Feb 24, 2017
Disallow UTF-8 Byte Order Marks in the source tree. That Node can read these files is still tested by `test/sequential/test-module-loading.js`. PR-URL: #11479 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Member
|
This would need a backport PR for v6 and v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
eslint